Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grubconfig: handle efi vendordir better #633

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

HuijingHei
Copy link
Member

Fix #630

Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sane to me, thanks!

(Longer term we need to stop hardcoding shim...that's it's own issue though)

@cgwalters
Copy link
Member

Just one unused import to fix from CI

@cgwalters cgwalters merged commit f361266 into coreos:main Mar 26, 2024
9 checks passed
@HuijingHei HuijingHei deleted the efi-vendor-dir branch March 26, 2024 13:27
@cgwalters
Copy link
Member

cgwalters commented Mar 26, 2024

Hmm, this may have actually broken things, bootc's CI runs with the -dev image that tracks git main started falling over, see

https://github.com/containers/bootc/actions/runs/8443222436/job/23126361204?pr=447

error: boot data installation failed: installing component EFI: Updating EFI firmware variables: Locating EFI vendordir: Failed to find EFI vendor dir

@HuijingHei
Copy link
Member Author

HuijingHei commented Mar 27, 2024

Sorry, aarch64 does not have shimx64.efi, seems we should use shimaa64.efi instead.

HuijingHei added a commit to HuijingHei/bootupd that referenced this pull request Mar 27, 2024
HuijingHei added a commit to HuijingHei/bootupd that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

handle efi vendordir better
2 participants