Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mdbook-linkcheck to CI #521

Closed
jeckersb opened this issue May 13, 2024 · 2 comments · Fixed by #535
Closed

Add mdbook-linkcheck to CI #521

jeckersb opened this issue May 13, 2024 · 2 comments · Fixed by #535
Assignees

Comments

@jeckersb
Copy link
Contributor

https://github.com/Michael-F-Bryan/mdbook-linkcheck

I've been catching these manually[1], but unsurprisingly computers are better at parsing things than my fallible biological parser.

[1] https://github.com/containers/bootc/pull/520/files/615ead5c9cc85066ef07af1da5321d1c112acc4f#diff-e0b4a488eccbd4e71db5387b0916834520b83da8da89b17f1842760ffd5e1963

@jeckersb jeckersb self-assigned this May 13, 2024
jeckersb added a commit to jeckersb/bootc that referenced this issue May 13, 2024
Fixes containers#521

Signed-off-by: John Eckersberg <jeckersb@redhat.com>
jeckersb added a commit to jeckersb/bootc that referenced this issue May 14, 2024
Fixes containers#521

Signed-off-by: John Eckersberg <jeckersb@redhat.com>
jeckersb added a commit to jeckersb/bootc that referenced this issue May 14, 2024
Fixes containers#521

Signed-off-by: John Eckersberg <jeckersb@redhat.com>
jeckersb added a commit to jeckersb/bootc that referenced this issue May 14, 2024
Fixes containers#521

Signed-off-by: John Eckersberg <jeckersb@redhat.com>
@cgwalters cgwalters reopened this May 15, 2024
@cgwalters
Copy link
Collaborator

OK I had to revert this as it broke the site. I only dug in a bit but I think the problem is that the linkcheck run seems to add a new top-level linkcheck/ directory in the output paralleling the html/ directory from the main run.

We could probably just remove it. Or, maybe we don't need to run link check on the main build?

Needs some investigation and testing.

jeckersb added a commit to jeckersb/bootc that referenced this issue May 15, 2024
Fixes containers#521

Signed-off-by: John Eckersberg <jeckersb@redhat.com>
@jeckersb
Copy link
Contributor Author

OK I had to revert this as it broke the site. I only dug in a bit but I think the problem is that the linkcheck run seems to add a new top-level linkcheck/ directory in the output paralleling the html/ directory from the main run.

We could probably just remove it. Or, maybe we don't need to run link check on the main build?

Needs some investigation and testing.

Of course I just read this after I wrote #533 (comment)

So yes, that's the problem. We might as well run linkcheck again on the main build, but we just need to upload the artifacts correctly with the right path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants