-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: Add an edit
verb
#107
Conversation
This interactively replaces the specified state, in a similar way as `kubectl edit`. As of right now, the only supported state to change is the desired image. But this will help unblock [configmap support]. [configmap support]: containers#22 Signed-off-by: Colin Walters <walters@verbum.org>
One thing that probably needs to happen here is we need to implement more of an "api server" in having at least a Also a random thought: we probably still do want to run as a systemd unit when changes are being made. But we could just always serialize our state into |
wdyt of adding an |
That's how it works right? You can |
yeah that is how it works, I was just wondering if it made sense to use the word 'apply' instead for that. As that is how kubectl and oc do it, which would be a more familiar interface I guess. |
In any case this lgtm. Just wanted to point out the "word" used as it might be more familiar to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
It's a good point! I'm not sure... we could make |
To be clear I'm happy to change to |
Well I think we need both if we want the "familiar interface". IIRC apply is just for when we are passing the yaml file. https://kubernetes.io/docs/reference/generated/kubectl/kubectl-commands#apply Edit is more manual, expects the user to modify it with an editor: But Idk, I see that edit also has a -f filename option which I am not sure if it just does the same thing as apply... If it does, then I guess we can ignore apply for now. |
Depends #106
cli: Add an
edit
verbThis interactively replaces the specified state, in a similar way
as
kubectl edit
.As of right now, the only supported state to change is the desired
image.
But this will help unblock configmap support.