Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: Add missing link to internal doc #164

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

pablomh
Copy link
Contributor

@pablomh pablomh commented Oct 31, 2023

No description provided.

@openshift-ci
Copy link

openshift-ci bot commented Oct 31, 2023

Hi @pablomh. Thanks for your PR.

I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, @pablomh !

CI fails because the commit needs the Signed-off-by signature (https://github.com/containers/bootc/pull/164/checks?check_run_id=18221847947). You can do that via git commit -s --amend and repushing.

Signed-off-by: Pablo Méndez Hernández <pablomh@gmail.com>
@pablomh
Copy link
Contributor Author

pablomh commented Oct 31, 2023

I noticed :/ I've added it and it should be in a better shape :)

@cgwalters cgwalters merged commit 82a6a5a into containers:main Oct 31, 2023
1 check passed
@pablomh pablomh deleted the patch-1 branch October 31, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants