install: Drop --net=none suggestion
#181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it's actually nice to show that the container can just install itself, I'm trying to reduce the command line length of the invocation in the interest of simplicity. There's a minor cost here as it means we'll get a default bridge network, but that hardly matters. Anyone who wants to avoid it can just specify `--net=none` on their own. However this said, I think longer term we do want to support networking at install time in order to do things like fetch configmaps, so dropping this is prep for that too. Signed-off-by: Colin Walters <walters@verbum.org>
jlebon
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it's actually nice to show that the container can just install itself, I'm trying to reduce the command line length of the invocation in the interest of simplicity.
There's a minor cost here as it means we'll get a default bridge network, but that hardly matters. Anyone who wants to avoid it can just specify
--net=noneon their own.However this said, I think longer term we do want to support networking at install time in order to do things like fetch configmaps, so dropping this is prep for that too.