-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: additional details around bootc images, install #195
Conversation
Hi @miabbott. Thanks for your PR. I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This adds more verbose details about composing base images and makes some Markdown syntax improvements. Signed-off-by: Micah Abbott <miabbott@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks sane after conflicts are fixed
54afd13
to
30c18cf
Compare
docs/install.md
Outdated
<image> \ | ||
bootc install-to-filesystem --replace=alongside /target | ||
```bash | ||
$ podman run --privileged -v /:/target \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lost --rm
in merge resolution
While the patient is open, what do you think of reflowing these lines of text to not be separated by new lines? The side effect being that changes to content should be easier to visualize rather than the multiple changed lines? |
No strong opinion honestly |
/ok-to-test |
I added some additional details around the install process and did Markdown cleanups, spelling corrections, grammar fixes, etc. Signed-off-by: Micah Abbott <miabbott@redhat.com>
|
||
Here's an example: | ||
Here's an example of using `bootc install` (root/elevated permission required): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to have copy-paste examples in the docs. I have encountered a number of issues trying to bootc-install in a pet VM.
"Boot this image, then do ..., then do a podman-run ...bootc install ...
".
I tried to add some clarifying details/context around the how to build "bootc compatible" images and how they are installed.
Generally spruced up the Markdown syntax and cleaned up some spelling/grammar nits.
This replaces #189