Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: apply clippy fix for needless borrowing #197

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

miabbott
Copy link
Contributor

See: https://rust-lang.github.io/rust-clippy/master/index.html#/needless_borrow

Applied cargo clippy --fix --lib -p bootc-lib

See: https://rust-lang.github.io/rust-clippy/master/index.html#/needless_borrow

Applied `cargo clippy --fix --lib -p bootc-lib`

Signed-off-by: Micah Abbott <miabbott@redhat.com>
Copy link
Collaborator

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly it's this clippy lint that made me give up on running clippy regularly...99% of the time it's noise and I'd lean more towards adding a default ignore for it.

But this is obviously correct as is too

@cgwalters cgwalters merged commit 0088fda into containers:main Nov 10, 2023
9 checks passed
@miabbott miabbott deleted the clippy branch November 11, 2023 15:15
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late LGTM
Trying to review as much as Rust as possible to get up to speed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants