install: Update to new bootupd uuid/EFI code #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
cgwalters
force-pushed
the
install-efi-uuid
branch
from
788eeb8
to
2b766d1
Compare
cgwalters
force-pushed
the
install-efi-uuid
branch
2 times, most recently
from
b132449
to
5743007
Compare
cgwalters
force-pushed
the
install-efi-uuid
branch
from
5743007
to
bc0737c
Compare
Because we'll be relying on newer bootupd bits. Signed-off-by: Colin Walters <walters@verbum.org>
This significantly simplifies this code even more; bootupd takes care of writing the UUID files in both places (like coreos-installer does). It also calls out to `efibootmgr` by default. Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
install-efi-uuid
branch
from
bc0737c
to
c920cbd
Compare
|
OK, this one should be good to review. |
vrothberg
reviewed
Nov 27, 2023
There was a problem hiding this comment.
@cgwalters shall we update the image references to the new repository/namespace/name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This significantly simplifies this code even more; bootupd takes care of writing the UUID files in both places (like coreos-installer does).
It also calls out to
efibootmgrby default.