Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: Don't retarget /tmp or /var/tmp if they're not overlayfs #225

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

cgwalters
Copy link
Collaborator

It may be that we're involved via a container flow where e.g. /tmp is already "properly" set up as a tmpfs.

In that case we don't need to do a dance in retargeting.

xref osbuild/bootc-image-builder#18 (comment)

It may be that we're involved via a container flow where
e.g. `/tmp` is already "properly" set up as a tmpfs.

In that case we don't need to do a dance in retargeting.

xref osbuild/bootc-image-builder#18 (comment)

Signed-off-by: Colin Walters <walters@verbum.org>
Copy link
Contributor

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just tested this commit in an osbuild environment and it works fine:

TRACE Already have /tmp with f_type=16914836
TRACE Already have /var/tmp with f_type=2435016766

Thanks!

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg vrothberg merged commit 2582ef2 into containers:main Dec 15, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants