Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install: Rename install -> install to-disk, peer with to-filesystem #226

Merged
merged 3 commits into from
Dec 15, 2023
Merged

install: Rename install -> install to-disk, peer with to-filesystem #226

merged 3 commits into from
Dec 15, 2023

Commits on Dec 15, 2023

  1. install: Rename install -> install to-disk, peer with `to-filesys… 

    …tem`

Take the current `install` verb and change it to be
`bootc install to-disk`, and then `install-to-filesystem` becomes
`bootc install to-filesystem` - they are obvious peers.

The main motivation here is that in the end many use cases will
want nontrivial filesystem customization, and while I like having
a fully opinionated builtin flow to write to a target disk,
we should really think of `to-filesystem` as a fully equal peer
of `to-disk`.

Signed-off-by: Colin Walters <walters@verbum.org>
    @cgwalters
    cgwalters committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    b831efb View commit details
    Browse the repository at this point in the history

  2. install-to-disk: Verify target is a block device 

    I saw someone get confused and think `bootc install` could work
on a filesystem.

Signed-off-by: Colin Walters <walters@verbum.org>
    @cgwalters
    cgwalters committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    ffe46d8 View commit details
    Browse the repository at this point in the history

  3. install-to-filesystem: Verify target is a dir+mountpoint 

    Similarly to previous patch for `install to-disk`, verify
that the target is a directory *and* that it's a mountpoint (we
can't sanely support installing to a subdirectory of a filesystem).

Signed-off-by: Colin Walters <walters@verbum.org>
    @cgwalters
    cgwalters committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    7997f57 View commit details
    Browse the repository at this point in the history