Fix clippy warnings

[jeckersb]

No description provided.

[openshift-ci]

Hi @jeckersb. Thanks for your PR.

I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jeckersb]

Related, I noticed CONTRIBUTING.md explicitly asks for cargo fmt and cargo clippy to be run on submissions, but that the CI workflow is non-gating for clippy. Do we want to make it gating to avoid requiring additional fixup patches like this in the future?

[cgwalters]

I did
#237

Related, I noticed CONTRIBUTING.md explicitly asks for cargo fmt and cargo clippy to be run on submissions, but that the CI workflow is non-gating for clippy. Do we want to make it gating to avoid requiring additional fixup patches like this in the future

Definitely cargo fmt but as of recently in projects I work on I've been backing off blocking on clippy in CI. Although we probably should gate on the correctness lints. Searching around I found this example.

[jeckersb]

Definitely cargo fmt but as of recently in projects I work on I've been backing off blocking on clippy in CI. Although we probably should gate on the correctness lints. Searching around I found this example.

Reading through the description of the lint groups, I think clippy::correctness and clippy::suspicious is probably a good place to start. I think clippy::complexity and clippy::perf are also decent candidates but more likely to throw false positives. All of the stuff fixed in this PR is clippy::style and I agree not to gate on that stuff.

[cgwalters]

/ok-to-test