-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HostType
, change status
to always succeed
#244
Conversation
Skipping CI for Draft Pull Request. |
For reference on a non-bootc enabled host the output looks like
With the important bit here being Whereas on a bootc-enabled system it will look like e.g.:
Though one corner case right now is on an ostree-but-not-bootc system (e.g. current FCOS,Fedora IoT) we show e.g.
Which is probably wrong. Will fix that. |
This looks good to me. The logic would be something like:
Does that sound right? |
Probably better to match on this being "bootcHost" instead of non-null, since under the current state this could also return "bootcContainer" (though you shouldn't see that from a "general observability" perspective). But the more general concern is that the enumeration is non-exhaustive, so in the future could contain new states like (totally contrived example) bootcTransitioning where the system is in the process of becoming managed by bootc but not quite completed. You probably don't want to consider that to be "bootc managed" yet. |
works for me |
87f95fc
to
257db2a
Compare
257db2a
to
d0109ac
Compare
Closes: containers#242 Basically it'd be useful for folks to be able to run `bootc status --json` and have that always work - if we're not on a bootc-booted system then we just output null data. Specifically we drop the `isContainer` field and replace it with an optional non-exhaustive enumeration. For anything we don't know about we just output `None` i.e. `null` in JSON. Signed-off-by: Colin Walters <walters@verbum.org>
d0109ac
to
69a7f37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This depends on #241
Add
HostType
, changestatus
to always succeedCloses: #242
Basically it'd be useful for folks to be able to run
bootc status --json
and have that always work - if we're not on a bootc-booted system
then we just output null data.
Specifically we drop the
isContainer
field and replace itwith an optional non-exhaustive enumeration. For anything we don't
know about we just output
None
i.e.null
in JSON.