Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install: add --source-imgref #263

Merged
merged 3 commits into from
Jan 17, 2024
Merged

install: add --source-imgref #263

merged 3 commits into from
Jan 17, 2024

Commits on Jan 17, 2024

  1. blockdev: fix recognizing parent loop devices 

    lsblk returns TYPE == loop for loop devices, modify the code
so loop devices are correctly recognized.

Signed-off-by: Ondřej Budai <ondrej@budai.cz>
    @ondrejbudai
    ondrejbudai committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    c3d595c View commit details
    Browse the repository at this point in the history

  2. install: make the source digest optional 

    This is a prep work for the following commit. It will implement pulling
the container image from an explicitly given container reference. Thus,
there's no need to always fetch the digest because the caller is being
explicit about the container image, so let's make the field optional.

Signed-off-by: Ondřej Budai <ondrej@budai.cz>
    @ondrejbudai
    ondrejbudai committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    cad0718 View commit details
    Browse the repository at this point in the history

  3. install: add --source-imgref 

    bootc install and install-to-filesystem currently rely on the fact that they
run inside a podman container. That's quite inconvenient for using bootc
for osbuild, because osbuild already run everything in a container.
While having a container in a container is surely possible, it gets quite
messy.

Instead of going this route, this commit implements a new --source-imgref
argument. --source-imgref accepts a container image reference (the same one
that skopeo uses). When --source-imgref is used, bootc doesn't escape the
container to fetch the container image from host's container storage. Instead,
the container image given by --source-imgref is used.

Even when running in this mode, bootc needs to run in a container created from
the same container image that is passed using --source-imgref. However, this
isn't a problem to do in osbuild. This really just removes the need for bootc
to escape the container to the host mount namespace.

Signed-off-by: Ondřej Budai <ondrej@budai.cz>
    @ondrejbudai
    ondrejbudai committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    7c3ed0b View commit details
    Browse the repository at this point in the history