Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: Don't unshare if we have an external source #275

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

cgwalters
Copy link
Collaborator

This was being done in osbuild work to use bootc install, so we might as well make it automatic. The environment variable was not intended as more than a debugging aid.

This was being done in osbuild work to use `bootc install`,
so we might as well make it automatic.  The environment
variable was not intended as more than a debugging aid.

Signed-off-by: Colin Walters <walters@verbum.org>
Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link

openshift-ci bot commented Jan 19, 2024

@cgwalters: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/kola-run eb620cc link true /test kola-run

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cgwalters cgwalters merged commit ec59a16 into containers:main Jan 19, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/install Issues related to `bootc install`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants