Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: Add more error contexts #276

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

cgwalters
Copy link
Collaborator

I forgot to bind mount -v /:/target and got an unfriendly bare
ERROR No such file or directory (os error 2)

Add more error context.

I forgot to bind mount `-v /:/target` and got an unfriendly
bare
`ERROR No such file or directory (os error 2)`

Add more error context.

Signed-off-by: Colin Walters <walters@verbum.org>
@github-actions github-actions bot added the area/install Issues related to `bootc install` label Jan 19, 2024
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Interesting to see the differences between languages. Go usually adds paths to error messages.

@cgwalters
Copy link
Collaborator Author

Yeah, creating error messages like that requires heap allocations in general, and Rust doesn't do that by default.

@cgwalters
Copy link
Collaborator Author

/override ci/prow/kola-run
Unrelated

Copy link

openshift-ci bot commented Jan 19, 2024

@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/kola-run

In response to this:

/override ci/prow/kola-run
Unrelated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters cgwalters merged commit f8f3af1 into containers:main Jan 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/install Issues related to `bootc install`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants