install: Automatically enable --generic-image when --via-loopback #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
warn-via-loopback-generic
branch
from
00b8506
to
9ed2245
Compare
It's a bit confusing because `to-disk` is intended primarily for *per machine* installs. However, when used with `--via-loopback` it can be used to make disk images which are probably intended to be generic. For now, let's just automatically flip that on. Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
warn-via-loopback-generic
branch
from
9ed2245
to
047ce72
Compare
vrothberg
approved these changes
Jan 29, 2024
mvo5
reviewed
Jan 29, 2024
| let mut block_opts = opts.block_opts; | ||
| let target_blockdev_meta = block_opts | ||
| .device | ||
| .metadata() | ||
| .with_context(|| format!("Querying {}", &block_opts.device))?; | ||
| if opts.via_loopback { | ||
| if !opts.config_opts.generic_image { | ||
| eprintln!("Automatically enabling --generic-image when installing via loopback"); | ||
| std::thread::sleep(std::time::Duration::from_secs(2)); |
There was a problem hiding this comment.
Just to double check, this sleep is here so that a user can quickly ctrl-c in case that is not what they want?
There was a problem hiding this comment.
More to annoy them into specifying it, while not entirely locking out the use case of writing to a loopback device in this mode - I can't think of a real use case, but maybe there is one.
There was a problem hiding this comment.
mm nevermind, I guess it is locked out because we hardcode it for now, but the goal is to make people specify it explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a bit confusing because
to-diskis intended primarily for per machine installs. However, when used with--via-loopbackit can be used to make disk images which are probably intended to be generic.For now, let's just automatically flip that on.