-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blockdev: Use --direct-io=on for losetup #375
Conversation
This is what other projects do; it avoids double buffering and is generally a good idea. Signed-off-by: Colin Walters <walters@verbum.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for being explicit here. One thing to note is that I'm pretty sure this is not strictly necessary per util-linux/util-linux@5b3bb7d -- the manpage was wrong and 'on' was always the default. The manpage on stream9 still has the older incorrect version.
The manpage was saying Testing this
Notice the composefs mount is using DIO but the loopback mount I did is not. |
Ah gotcha. My English parser is buggy 😆 |
Yeah, the code in https://github.com/util-linux/util-linux/blob/master/sys-utils/losetup.c#L687 also indicates the default is "off". But this is super nice, we will try this for osbuild too. |
See e.g. containers/bootc#375 (comment) The phrasing here was in my opinion technically correct but quite confusing and easy to misunderstand. Let's be very clear: - The default is *off* - You can turn it on in two ways - You can also explicitly turn it off
See e.g. containers/bootc#375 (comment) The phrasing here was in my opinion technically correct but quite confusing and easy to misunderstand. Let's be very clear: - The default is *off* - You can turn it on in two ways - You can also explicitly turn it off Signed-off-by: Colin Walters <walters@verbum.org>
See e.g. containers/bootc#375 (comment) The phrasing here was in my opinion technically correct but quite confusing and easy to misunderstand. Let's be very clear: - The default is *off* - You can turn it on in two ways - You can also explicitly turn it off Signed-off-by: Colin Walters <walters@verbum.org>
See e.g. containers/bootc#375 (comment) The phrasing here was in my opinion technically correct but quite confusing and easy to misunderstand. Let's be very clear: - The default is *off* - You can turn it on in two ways - You can also explicitly turn it off Signed-off-by: Colin Walters <walters@verbum.org>
This is what other projects do; it avoids double buffering and is generally a good idea.