Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More image output cleanup #399

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

cgwalters
Copy link
Collaborator

deploy: Use alternative format for staging

Followup to e3db010
where this one was missed. Copy-pasting that git log
for ease of consumption:

Same motivation as ostreedev/ostree-rs-ext#604

Because fetching from a registry with the default sigverify is
the 90% case default, when we see this (and are formatting for
human consumption), use the "alternate" formatting to just
display the image name.

This makes the ostree stuff much less in the user's face
in the default path.

Signed-off-by: Colin Walters walters@verbum.org


install: Clean up image output more

Ensure we use alternative formatting for the image reference
for consistency.

And move the image output (including digest) to the very
start where it's more centralized.

Signed-off-by: Colin Walters walters@verbum.org


Followup to e3db010
where this one was missed.  Copy-pasting that git log
for ease of consumption:

Same motivation as ostreedev/ostree-rs-ext#604

Because fetching from a registry with the default sigverify is
the 90% case default, when we see this (and are formatting for
human consumption), use the "alternate" formatting to just
display the image name.

This makes the ostree stuff *much* less in the user's face
in the default path.

Signed-off-by: Colin Walters <walters@verbum.org>
Ensure we use alternative formatting for the image reference
for consistency.

And move the image output (including digest) to the very
start where it's more centralized.

Signed-off-by: Colin Walters <walters@verbum.org>
@github-actions github-actions bot added the area/install Issues related to `bootc install` label Mar 18, 2024
@cgwalters
Copy link
Collaborator Author

@sallyom this will fix the issue you saw

@cgwalters cgwalters requested a review from jeckersb March 18, 2024 22:27
Copy link
Contributor

@jbtrystram jbtrystram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgwalters cgwalters merged commit bedaccf into containers:main Mar 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/install Issues related to `bootc install`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants