Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: Add block to config, disable tpm2-luks unless opted-in #445

Merged
merged 2 commits into from
Apr 3, 2024

Commits on Mar 26, 2024

  1. tests: Use ..Default::default() for install config

    To make adding a new field not require touching all the tests.
    
    Signed-off-by: Colin Walters <walters@verbum.org>
    cgwalters committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    2108921 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. install: Add block to config, disable tpm2-luks unless opted-in

    This allows the container image builder more control over
    `bootc install to-disk` in the installation config.  Per discussion in
    containers#421
    this one definitely requires integration by the base image,
    and not all of them will want it.
    
    (Or if the do want LUKS, they may want more control over it)
    
    The default value is `block: ["direct"]` which only enables
    the simple filesystem install.
    
    This change allows two different things:
    
    `block: []`
    
    With this, `bootc install to-disk` will just error out.  It's
    a way to effectively disable it for those that want to use
    an external installer always.
    
    Another possibility is:
    
    `block: ["direct", "tpm2-luks"]`
    
    To explicitly re-enable the builtin tpm2-luks flow.
    
    Or, one could do just `block: ["tpm2-luks"]` to enforce encrypted installs.
    
    Signed-off-by: Colin Walters <walters@verbum.org>
    cgwalters committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    a615e2b View commit details
    Browse the repository at this point in the history