Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Various updates and fixes #450

Merged
merged 1 commit into from
Mar 29, 2024
Merged

docs: Various updates and fixes #450

merged 1 commit into from
Mar 29, 2024

Conversation

cgwalters
Copy link
Collaborator

I went through the docs and cleaned some things up, fixed some missing content, etc.

Also a patch to xtask to make it so that cargo xtask manpages works even when $PWD is in docs.

@jeckersb jeckersb self-requested a review March 29, 2024 15:27
jeckersb
jeckersb requested changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@jeckersb jeckersb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me, just noted a couple of minor things

docs/src/man/bootc-rollback.md Outdated Show resolved Hide resolved
docs/src/upgrades.md Show resolved Hide resolved
docs/src/man/bootc-upgrade.md Outdated Show resolved Hide resolved
docs/src/man/bootc-usr-overlay.md Outdated Show resolved Hide resolved
@jeckersb jeckersb enabled auto-merge March 29, 2024 18:08
@cgwalters
docs: Various updates and fixes
d2ddaac 
I went through the docs and cleaned some things up, fixed
some missing content, etc.

Also a patch to `xtask` to make it so that `cargo xtask manpages`
works even when $PWD is in `docs`.

Signed-off-by: Colin Walters <walters@verbum.org>
@cgwalters
Copy link
Collaborator Author

OK the git rev-parse failure is weird; took a stab at both propagating stderr to aid debugging, and I'm guessing it's the git "safe directory" stuff so I cargo culted a bit for that.

@cgwalters
Copy link
Collaborator Author

Ah yes, my intuition about the safe directory bits was right 😄

@cgwalters cgwalters disabled auto-merge March 29, 2024 18:39
@cgwalters cgwalters merged commit a4cf3ff into containers:main Mar 29, 2024
14 of 15 checks passed
@cgwalters
Copy link
Collaborator Author

(force merging since we had green CI before)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeckersb jeckersb jeckersb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgwalters @jeckersb