install: Support being passed --filesystem with no install config #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
install-config-optional
branch
from
a5fd30d
to
42ae54f
Compare
cgwalters
changed the title
cgwalters
force-pushed
the
install-config-optional
branch
2 times, most recently
from
36074f9
to
3f86d56
Compare
jeckersb
requested changes
Apr 22, 2024
This fixes a logical bug where for base images that don't have any install configuration at all, we errored out even if we were explicitly passed `--filesystem`. This is just about making it easier to test base images that don't have an install config. Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
install-config-optional
branch
from
3f86d56
to
88ba172
Compare
jeckersb
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a logical bug where for base images that don't have any install configuration at all, we errored out even if we were explicitly passed
--filesystem.This is just about making it easier to test base images that don't have an install config.