install: Add prominent warning+timeout when targeting host root #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was raised in a discussion that it's rather easy to copy-paste this command you may find in a document and not fully understand what it does. Let's prominently warn by default, with a timeout. Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
install-to-filesystem-warning-more
branch
from
85a2fcf
to
dcd42f7
Compare
Especially the `-t` forces as pty allocation which causes bad rendering for things like progress bars in the github actions flow. Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
install-to-filesystem-warning-more
branch
from
1f4fecf
to
2094895
Compare
jeckersb
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was raised in a discussion that it's rather easy to copy-paste this command you may find in a document and not fully understand what it does.
Let's prominently warn by default, with a timeout.