Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSRV to 1.75 #508

Merged
merged 1 commit into from
May 3, 2024
Merged

Update MSRV to 1.75 #508

merged 1 commit into from
May 3, 2024

Conversation

jeckersb
Copy link
Contributor

@jeckersb jeckersb commented May 3, 2024

Currently the effective MSRV is 1.74.1 per cargo msrv. We have 1.75
available in c9s, so let's target that at minimum.

Signed-off-by: John Eckersberg jeckersb@redhat.com

@jeckersb jeckersb changed the title CI: Add check on msrv Add CI for MSRV and bump MSRV to 1.75 May 3, 2024
@jeckersb jeckersb force-pushed the ci-msrv branch 2 times, most recently from f34bacd to 998632f Compare May 3, 2024 18:04
Copy link
Collaborator

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for now our baseline target should be CentOS Stream 9. It stays relatively up to date. We could have a periodic job that polls the latest c9s and bumps our MSRV to whatever rust version it finds there.

Trying to actually validate the MSRV by installing that toolchain version sounds nice too in addition, but I think the larger problem is that the MSRV is just stale and automating bumping it is the general fix.

@jeckersb
Copy link
Contributor Author

jeckersb commented May 3, 2024

I think for now our baseline target should be CentOS Stream 9. It stays relatively up to date. We could have a periodic job that polls the latest c9s and bumps our MSRV to whatever rust version it finds there.

Trying to actually validate the MSRV by installing that toolchain version sounds nice too in addition, but I think the larger problem is that the MSRV is just stale and automating bumping it is the general fix.

Yeah that's basically the conclusion I'm reaching too, as I run awkwardly into the wall trying to do the validation. I'll prune this back to just do the manual version bump for now and then look into how the periodic jobs work.

Currently the effective MSRV is 1.74.1 per `cargo msrv`.  We have 1.75
available in c9s, so let's target that at minimum.

Signed-off-by: John Eckersberg <jeckersb@redhat.com>
@jeckersb jeckersb changed the title Add CI for MSRV and bump MSRV to 1.75 Update MSRV to 1.75 May 3, 2024
@jeckersb jeckersb marked this pull request as ready for review May 3, 2024 19:57
@cgwalters cgwalters merged commit 189adfe into containers:main May 3, 2024
12 of 17 checks passed
@jeckersb jeckersb linked an issue May 3, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSRV is broken
2 participants