install: A few minor patches #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can take substantial time. Signed-off-by: Colin Walters <walters@verbum.org>
We previously changed the rootfs `mkfs` invocation to be verbose; for consistency let's do the same for the EFI partition as well as the bootloader run just so people can see what's going on more. Signed-off-by: Colin Walters <walters@verbum.org>
It's the default. Signed-off-by: Colin Walters <walters@verbum.org>
|
I think we can ignore the failing tests here, the |
jeckersb
approved these changes
May 21, 2024
| "--device", | ||
| device.as_str(), | ||
| rootfs.as_str(), | ||
| ]); | ||
| Task::new_and_run("Running bootupctl to install bootloader", "bootupctl", args) | ||
| Task::new("Running bootupctl to install bootloader", "bootupctl") |
There was a problem hiding this comment.
👍 I know @bcrochet ran into this before when I was shoulder surfing with him.
| let imgstate = | ||
| ostree_container::deploy::deploy(&sysroot, stateroot, &src_imageref, Some(options)).await?; | ||
| println!("Deployment complete"); | ||
| let imgstate = crate::utils::async_task_with_spinner( |
There was a problem hiding this comment.
👍 I sanity checked this on my system, it was too fast to actually see the spinner but I verified it omits the Deployment complete output and instead just puts out done as expected. I'm assuming if the deployment was slower I would see the actual spinner 😄
|
On Tue, May 21, 2024, at 2:07 PM, John Eckersberg wrote:
👍 I sanity checked this on my system, it was too fast to actually see
the spinner but I verified it omits the `Deployment complete` output
and instead just puts out `done` as expected. I'm assuming if the
deployment was slower I would see the actual spinner 😄
If you're testing with podman-bootc you need
containers/podman-bootc#37
and its followup in containers/podman-bootc#41
to see the spinner.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install: Add a spinner for container deployment
This can take substantial time.
Signed-off-by: Colin Walters walters@verbum.org
install: Be verbose for EFI creation and bootloader install
We previously changed the rootfs
mkfsinvocation to beverbose; for consistency let's do the same for the EFI partition
as well as the bootloader run just so people can see
what's going on more.
Signed-off-by: Colin Walters walters@verbum.org
bootloader: Drop --src-root /
It's the default.
Signed-off-by: Colin Walters walters@verbum.org