Makefile: Serialize tarballs reproducibly #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeckersb
approved these changes
Jun 6, 2024
| @@ -1,5 +1,9 @@ | |||
| prefix ?= /usr | |||
|
|
|||
| SOURCE_DATE_EPOCH ?= $(shell git log -1 --pretty=%ct) | |||
| # https://reproducible-builds.org/docs/archives/ | |||
There was a problem hiding this comment.
❤️
This was a good read, I especially like this bit, given our recent discussions:
Care must be taken to ensure that sort is called in the context of the C locale to avoid any surprises related to collation order.
There was a problem hiding this comment.
Right; the doc mentions that GNU tar's --sort=name is always locale insensitive.
This ensures that when we rerun the container build without changing the source, we get the same thing. Which then further ensures we don't invalidate any cached disk images, etc. Signed-off-by: Colin Walters <walters@verbum.org>
jeckersb
force-pushed
the
makefile-reproducible
branch
from
fcc9bc7
to
91ed63c
Compare
|
Test was a generic timeout issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that when we rerun the container build without changing the source, we get the same thing. Which then further ensures we don't invalidate any cached disk images, etc.