Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status: Use prepare_for_write instead of require_root #595

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

ckyrouac
Copy link
Contributor

This prevents /sysroot from switching to being
persistently mounted as rw.

@cgwalters
Copy link
Collaborator

I'm a bit confused since the link for "
Integration Test / integration (x86_64, rhel-9-5) (pull_request_target) Failing after 49m " to testing farm takes me to something for Fedora 40?

@cgwalters
Copy link
Collaborator

Ah, at least it looks like the integration tests are incorrectly testing for this behavior:

TASK [assert] ******************************************************************
fatal: [guest]: FAILED! => changed=false 
  assertion: result_sysroot_mount_status.stdout == "rw"
  evaluated_to: false
  msg: /sysroot is not mounted with rw permission

This prevents /sysroot from switching to being
persistently mounted as rw.

Signed-off-by: Chris Kyrouac <ckyrouac@redhat.com>
@cgwalters
Copy link
Collaborator

Not sure why the install tests suddenly started falling over with ENOSPC...trying to debug

@cgwalters cgwalters merged commit 559aca6 into containers:main Jun 12, 2024
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants