build: Install git too #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeckersb
reviewed
Jun 12, 2024
This must be a regression from the timestamp change: 91ed63c Without this we fail to parse the timestamp and get errors; maybe something else changed. Of course, we should use a non-Makefile language for this so we get proper error checking. I may move some of the makefile bits into xtask.rs or so. Signed-off-by: Colin Walters <walters@verbum.org>
|
Good call, changed to use git-core |
jeckersb
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This must be a regression from the timestamp change: 91ed63c
Without this we fail to parse the timestamp and get errors; maybe something else changed.
Of course, we should use a non-Makefile language for this so we get proper error checking. I may move some of the makefile bits into xtask.rs or so.