install/baseline: Drop separate /dev mount #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we hard require the host's `/dev`, let's drop our duplicate `devtmpfs` copy. My main motivation here is I wanted to add some other debugging and trying to invoke e.g. `lsblk` on our temporary copy doesn't work. With the combination of the host `/dev` plus our invocation of udev settling, we shouldn't hit races. Signed-off-by: Colin Walters <walters@verbum.org>
We've been seeing `mkfs` sometimes fail in CI, I think this will help debug. Signed-off-by: Colin Walters <walters@verbum.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we hard require the host's
/dev, let'sdrop our duplicate
devtmpfscopy. My main motivation here is I wanted to add some other debugging and trying to invoke e.g.lsblkon our temporary copy doesn't work.With the combination of the host
/devplus our invocation of udev settling, we shouldn't hit races.