HACKING.md: Clarify CONTAINER_CONNECTION
#614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Force pushed for DCO |
|
Minor procedural note; I try to use "topic prefix" style in git commits in my projects (like the Linux kernel and others) which would look more like:
|
This commit adds a note to `HACKING.md` to clarify that the environment variable `CONTAINER_CONNECTION` should be set to the name of the podman machine. As an inexperienced user of podman-machine, this detail was not obvious to me (containers#611). Signed-off-by: Omer Tuchfeld <omer@tuchfeld.dev>
|
sgtm |
omertuc
changed the title
CONTAINER_CONNECTION in HACKING.mdCONTAINER_CONNECTION
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a note to
HACKING.mdto clarify that the environmentvariable
CONTAINER_CONNECTIONshould be set to the name of the podmanmachine.
As an inexperienced user of podman-machine, this detail was not obvious
to me (#611).