Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Make sysroot lock automatically check root + setup mountns #619

Merged
merged 1 commit into from
Jun 21, 2024

Commits on Jun 20, 2024

  1. cli: Make sysroot lock automatically check root + setup mountns

    Previous to this change, we were always pairing together two
    functions:
    
    - `prepare_for_write()`
    - `get_locked_sysroot()`
    
    Make the latter automatically call the former (and make it private
    to the cli code).
    
    This will avoid bugs like containers@dcfc752
    where we forgot to call the first one and didn't end up with
    an unshared mountns.
    
    While we're here, drop an unnecessary `async` from these functions,
    and just in case make `prepare_for_write()` idempotent.
    
    Signed-off-by: Colin Walters <walters@verbum.org>
    cgwalters committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    b10a1fe View commit details
    Browse the repository at this point in the history