install: Make stateroot configurable #622
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
reviewed
Jun 21, 2024
|
For tests, try adding a new case to bootc/tests-integration/src/install.rs Line 68 in b5f47ff |
omertuc
force-pushed
the
installstateroot
branch
3 times, most recently
from
8e9e129
to
c093213
Compare
cgwalters
reviewed
Jun 26, 2024
This commit makes it so that the `bootc install` stateroot will be configurable (it defaults to `default`). For now this is a hidden CLI option until we decide whether we want to commit to this API. In the future we also want to make the stateroot of `bootc switch` be configurable (containers#617) so that users can install an image to a new stateroot while they already have an existing stateroot Also removed the constant `STATEROOT_DEFAULT`, we're now simply taking it from the `ostree_ext` crate
cgwalters
approved these changes
Jul 3, 2024
| @@ -158,6 +156,10 @@ pub(crate) struct InstallConfigOpts { | |||
| #[clap(long)] | |||
| #[serde(default)] | |||
| pub(crate) generic_image: bool, | |||
|
|
|||
| /// The stateroot name to use. Defaults to `default`. | |||
| #[clap(long, hide = true)] | |||
There was a problem hiding this comment.
We should at least debate: any reason not to stabilize (i.e. not hide = true) this? This really I guess is just the question of whether we want to tie bootc to the ostree concept of "stateroot" as is basically forever.
I think it's unlikely to be valuable for us to try to do anything really different here, so I'd say stabilize.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(draft because untested yet, also want to add integration tests)
This commit makes it so that the
bootc installstateroot will be configurable (it defaults todefault). For now this is a hidden CLI option until we decide whether we want to commit to this API.In the future we also want to make the stateroot of
bootc switchbe configurable (#617) so that users can install an image to a new stateroot while they already have an existing staterootAlso removed the constant
STATEROOT_DEFAULT, we're now simply taking it from theostree_extcrate