install: Support non EFI partition format #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch enables partition layouts that do not include EFI partition and/or boot partition. Without this patch, partition numbers becomes not consecutive, and subsequent findpart will fail. Signed-off-by: Yohei Ueda <yohei@jp.ibm.com>
cgwalters
approved these changes
Jun 21, 2024
| "0:+1M", | ||
| "BIOS-BOOT", | ||
| Some("21686148-6449-6E6F-744E-656564454649"), | ||
| ); | ||
| } else if cfg!(target_arch = "aarch64") { | ||
| // reserved | ||
| partno += 1; |
There was a problem hiding this comment.
(Tangential but at this point we can kill the reserved partition on aarch64, we don't have the same use case/problems that motivated it on CoreOS with having symmetry with x86_64 - makes sense in a followup)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch enables partition layouts that do not include EFI partition and/or boot partition.
Without this patch, partition numbers becomes not consecutive, and subsequent
findpartwill fail.