Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kargs: A few more minor cleanups and test improvements #648

Merged
merged 4 commits into from
Jun 28, 2024
Merged

kargs: A few more minor cleanups and test improvements #648

merged 4 commits into from
Jun 28, 2024

Commits on Jun 28, 2024

  1. kargs: Factor out helper function for ostree case 

    Just reducing the size of the main `get_kargs`.

Now that we've split out the helper, add a unit test.

Signed-off-by: Colin Walters <walters@verbum.org>
    @cgwalters
    cgwalters committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    b9ea8b6 View commit details
    Browse the repository at this point in the history

  2. kargs: De-indent ostree reading logic 

    Instead of nested `if`, use `continue` to de-indent.

Signed-off-by: Colin Walters <walters@verbum.org>
    @cgwalters
    cgwalters committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    e40e235 View commit details
    Browse the repository at this point in the history

  3. kargs: Add a few more comments 

    Signed-off-by: Colin Walters <walters@verbum.org>
    @cgwalters
    cgwalters committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    6ea1802 View commit details
    Browse the repository at this point in the history

  4. kargs: Factor out helper for filename matching 

    Since we have two different read paths.

Signed-off-by: Colin Walters <walters@verbum.org>
    @cgwalters
    cgwalters committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    6000633 View commit details
    Browse the repository at this point in the history