Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree-wide: Convert to let-else syntax #650

Merged
merged 1 commit into from
Jun 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/src/blockdev.rs
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,7 @@ impl LoopbackDevice {
// Shared backend for our `close` and `drop` implementations.
fn impl_close(&mut self) -> Result<()> {
// SAFETY: This is the only place we take the option
let dev = if let Some(dev) = self.dev.take() {
dev
} else {
let Some(dev) = self.dev.take() else {
tracing::trace!("loopback device already deallocated");
return Ok(());
};
Expand Down
4 changes: 1 addition & 3 deletions lib/src/containerenv.rs
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@ pub(crate) fn get_container_execution_info(rootfs: &Dir) -> Result<ContainerExec
for line in f.lines() {
let line = line?;
let line = line.trim();
let (k, v) = if let Some(v) = line.split_once('=') {
v
} else {
let Some((k, v)) = line.split_once('=') else {
continue;
};
// Assuming there's no quotes here
Expand Down
4 changes: 1 addition & 3 deletions lib/src/deploy.rs
Original file line number Diff line number Diff line change
Expand Up @@ -401,9 +401,7 @@ fn find_newest_deployment_name(deploysdir: &Dir) -> Result<String> {
continue;
}
let name = ent.file_name();
let name = if let Some(name) = name.to_str() {
name
} else {
let Some(name) = name.to_str() else {
continue;
};
dirs.push((name.to_owned(), ent.metadata()?.mtime()));
Expand Down
4 changes: 1 addition & 3 deletions lib/src/install.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1570,9 +1570,7 @@ pub(crate) async fn install_to_filesystem(
loop {
tracing::debug!("Finding parents for {dev}");
let mut parents = crate::blockdev::find_parent_devices(&dev)?.into_iter();
let parent = if let Some(f) = parents.next() {
f
} else {
let Some(parent) = parents.next() else {
break;
};
if let Some(next) = parents.next() {
Expand Down
8 changes: 2 additions & 6 deletions lib/src/kargs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@ impl Config {
/// a combined list.
pub(crate) fn get_kargs_in_root(d: &Dir, sys_arch: &str) -> Result<Vec<String>> {
// If the directory doesn't exist, that's OK.
let d = if let Some(d) = d.open_dir_optional("usr/lib/bootc/kargs.d")? {
d
} else {
let Some(d) = d.open_dir_optional("usr/lib/bootc/kargs.d")? else {
return Ok(Default::default());
};
let mut ret = Vec::new();
Expand Down Expand Up @@ -74,9 +72,7 @@ fn get_kargs_from_ostree(
while let Some(fetched_info) = fetched_iter.next_file(cancellable)? {
// only read and parse the file if it is a toml file
let name = fetched_info.name();
let name = if let Some(name) = name.to_str() {
name
} else {
let Some(name) = name.to_str() else {
continue;
};
if !Config::filename_matches(name) {
Expand Down
8 changes: 2 additions & 6 deletions xtask/src/xtask.rs
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,7 @@ fn manpages(sh: &Shell) -> Result<()> {
for ent in std::fs::read_dir(extradir)? {
let ent = ent?;
let srcpath = ent.path();
let extension = if let Some(extension) = srcpath.extension() {
extension
} else {
let Some(extension) = srcpath.extension() else {
continue;
};
if extension != "md" {
Expand Down Expand Up @@ -302,9 +300,7 @@ fn impl_srpm(sh: &Shell) -> Result<Utf8PathBuf> {
for e in std::fs::read_dir(td)? {
let e = e?;
let n = e.file_name();
let n = if let Some(n) = n.to_str() {
n
} else {
let Some(n) = n.to_str() else {
continue;
};
if n.ends_with(".src.rpm") {
Expand Down
Loading