blockdev+install updates #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 13, 2024
- Add `partlabel` in prep for ppc64le bootloader bits - Add `maj_min` and `start` which we want for s390x - Clearly move the filesystesm-related bits to a separate section Signed-off-by: Colin Walters <walters@verbum.org>
This way we continue to support the version of util-linux in C9S today. Signed-off-by: Colin Walters <walters@verbum.org>
I noticed that the JSON format inconsistently uses human-readable sizes for some properties, but not others. `size` happens to be one of the ones were it outputs human readable. But I think we will often want to operate on the raw byte value on our own, so let's tell lsblk to just give us raw numbers and do formatting where needed. While we're here, just hard require the `size` property. I don't think any block devices can be missing this. Signed-off-by: Colin Walters <walters@verbum.org>
The bootloader logic in general is going to need to query the block layout. But especially for ppc64le and s390x we'll need this data. Gather it early on as global state so it's accessible to the entire `install to-filesystem` phase. Note that we shouldn't be mutating the blockdev setup in `to-filesystem`. Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
blockdev-updates
branch
from
3be47ba
to
a08801b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series is prep for
blockdev: Get more properties
partlabelin prep for ppc64le bootloader bitsmaj_minandstartwhich we want for s390xsection
Signed-off-by: Colin Walters walters@verbum.org
blockdev: Backfill
startif missingThis way we continue to support the version of util-linux in C9S
today.
Signed-off-by: Colin Walters walters@verbum.org
blockdev: Use
-bfor lsblk, hard require size propertyI noticed that the JSON format inconsistently uses human-readable
sizes for some properties, but not others.
sizehappens tobe one of the ones were it outputs human readable. But I think
we will often want to operate on the raw byte value on our
own, so let's tell lsblk to just give us raw numbers and
do formatting where needed.
While we're here, just hard require the
sizeproperty.I don't think any block devices can be missing this.
Signed-off-by: Colin Walters walters@verbum.org
install: Gather blockdev info early in filesystem phase
The bootloader logic in general is going to need to
query the block layout. But especially for ppc64le and s390x
we'll need this data.
Gather it early on as global state so it's accessible
to the entire
install to-filesystemphase. Note thatwe shouldn't be mutating the blockdev setup in
to-filesystem.Signed-off-by: Colin Walters walters@verbum.org