install: Move re-exec earlier #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the comment says everything we do before `prepare_install` is something we might do *twice* so let's keep it as early as possible. Looking at the history of this code (and its logical inputs) I believe there's no reason for its placement in the middle of this function other than just "stuff appeared before it organically". Yes, it means some argument validation will happen after the re-exec but that's fine. Signed-off-by: Colin Walters <walters@verbum.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the comment says everything we do before
prepare_installis something we might do twice so let's keep it as early as possible.Looking at the history of this code (and its logical inputs) I believe there's no reason for its placement in the middle of this function other than just "stuff appeared
before it organically".
Yes, it means some argument validation will happen after the re-exec but that's fine.