Cmd pdeathsig #943
Merged
Cmd pdeathsig #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In almost all children we fork, we want the child to reliably exit if we do (e.g. especially if we panic). The Linux PR_SET_PDEATHSIG is just great for this. Signed-off-by: Colin Walters <walters@verbum.org>
I just happened to glance at this code, this gives us stderr in the error, etc. Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
cmd-pdeathsig
branch
from
fa9a992 to
479cbca
Compare
allisonkarlitskaya
approved these changes
Dec 10, 2024
| @@ -84,6 +88,19 @@ impl CommandRunExt for Command { | |||
| self.status()?.check_status(stderr) | |||
| } | |||
|
|
|||
| #[allow(unsafe_code)] | |||
| fn lifecycle_bind(&mut self) -> &mut Self { | |||
| // SAFETY: This API is safe to call in a forked child. | |||
There was a problem hiding this comment.
A docs reference would be good (even if it's just to say that this is implemented with prctl and point to the list in signal-safety manpage)...
There was a problem hiding this comment.
Hmm, the rustix docs for this function do link directly to the prctl man page right?
There was a problem hiding this comment.
I think while we could have more safety explanations in cases like this, what we have here is actually better than some of the other (few) unsafe cases and if we were to try to raise the bar we'd need to a bit more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utils: Add a lifecycle_bind helper for Command
In almost all children we fork, we want the child to reliably
exit if we do (e.g. especially if we panic). The Linux
PR_SET_PDEATHSIG is just great for this.
Signed-off-by: Colin Walters walters@verbum.org
utils: Use
runhelper for editorI just happened to glance at this code, this gives us stderr
in the error, etc.
Signed-off-by: Colin Walters walters@verbum.org