-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Meson build system to be able to run tests #475
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon McVittie <smcv@collabora.com>
Signed-off-by: Simon McVittie <smcv@collabora.com>
Signed-off-by: Simon McVittie <smcv@collabora.com>
smcv
force-pushed
the
meson
branch
4 times, most recently
from
February 19, 2022 15:41
39f36d2
to
d8be524
Compare
The python build option can be used to swap to a different interpreter, for environments like the Steam Runtime where the python3 executable in the PATH is extremely old but there is a better interpreter available. This is treated as non-optional, because Meson is written in Python, so the situation where there is no Python interpreter at build-time shouldn't arise. Signed-off-by: Simon McVittie <smcv@collabora.com>
Signed-off-by: Simon McVittie <smcv@collabora.com>
Signed-off-by: Simon McVittie <smcv@collabora.com>
Signed-off-by: Simon McVittie <smcv@collabora.com>
Signed-off-by: Simon McVittie <smcv@collabora.com>
This test is hanging when run under 'meson dist' for some reason, but not when run under 'meson test', and not locally, only in the Github Workflow-based CI. Disable it for now. Signed-off-by: Simon McVittie <smcv@collabora.com>
That version doesn't allow more than two arguments for define_variable. Signed-off-by: Simon McVittie <smcv@collabora.com>
smcv
changed the title
Fix Meson build system
Fix Meson build system to be able to run tests
Feb 20, 2022
@cgwalters, @alexlarsson or @mwleeds: would you mind taking a look at this? I'd like to do a bubblewrap 0.6.0 release (mainly for #432 and #453, https://github.com/containers/bubblewrap/releases/edit/untagged-a976e728bb68f2b6c8c5), but it seems silly for the first release with a Meson build system to have known bugs for which a solution is available. |
cgwalters
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like #432 was less complete than I had intended, sorry.
Successfully tested on Debian 10, Ubuntu 20.04, Debian 11 and Debian unstable.
meson.build: Remove unnecessary check for sh
meson: Build tests with equivalent of -I$(top_srcdir) -I$(top_builddir)
meson: Build the try-syscall helper
meson: Run the Python test script with Python, not bash
The python build option can be used to swap to a different interpreter,
for environments like the Steam Runtime where the python3 executable in
the PATH is extremely old but there is a better interpreter available.
This is treated as non-optional, because Meson is written in Python,
so the situation where there is no Python interpreter at build-time
shouldn't arise.
meson: Make G_TEST_SRCDIR, G_TEST_BUILDDIR match Autotools
meson: Run test scripts from $srcdir
tests: Fix compiler warnings for unused arguments
meson: Actually build and run the tests
Disable test-specifying-pidns.sh under 'meson dist' while I investigate
This test is hanging when run under 'meson dist' for some reason, but
not when run under 'meson test', and not locally, only in the Github
Workflow-based CI. Disable it for now.
meson: Improve compatibility with Meson 0.49
That version doesn't allow more than two arguments for define_variable.