This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
Support HTTP Basic authentication when fetching dependencies #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonboulle is this something you'd consider including? |
|
Wow, so sorry about not getting around to this. I'm just now getting back into acbuild development. I'll review this now. |
|
Would you be willing to move the |
cgonyeo
reviewed
Nov 30, 2016
|
|
||
| err := filepath.Walk(directory, func(path string, file os.FileInfo, err error) error { | ||
| if err != nil { | ||
| return nil |
There was a problem hiding this comment.
Maybe it would be better to log here what went wrong?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I need to be able to supply HTTP Basic auth as part of the discovery process, so I modeled an implementation off of the
rktfile format.Can you take a look and let me know if this is along the lines of what you were thinking?
Thanks!