Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New --exclude directive from Dockerfile #5678

Open
slinkydeveloper opened this issue Aug 8, 2024 · 9 comments · May be fixed by #5733
Open

New --exclude directive from Dockerfile #5678

slinkydeveloper opened this issue Aug 8, 2024 · 9 comments · May be fixed by #5733
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@slinkydeveloper
Copy link
Contributor

Feature request description

Dockerfile recently added support for the COPY --exclude parameter, see https://www.docker.com/blog/new-dockerfile-capabilities-v1-7-0/. Would it be possible to add it to podman too?

Suggest potential solution

A clear and concise description of what you want to happen.

Have you considered any alternatives?

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

@slinkydeveloper slinkydeveloper added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 8, 2024
@afbjorklund

This comment was marked as off-topic.

@rhatdan rhatdan transferred this issue from containers/podman Aug 9, 2024
@rhatdan
Copy link
Member

rhatdan commented Aug 9, 2024

This needs to bed enhanced in Buildah

Seems reasonable to me. But would require work in imagebuilder, I blieve.

@nalind @flouthoc WDYT?

@rhatdan
Copy link
Member

rhatdan commented Aug 9, 2024

If you were interested in opening a PR that would help this along.

@flouthoc
Copy link
Collaborator

flouthoc commented Aug 9, 2024

Yes imagebuilder changes are needed afaics, I can give this a stab if @slinkydeveloper is not already working on this.

@nalind
Copy link
Member

nalind commented Aug 9, 2024

The imagebuilder parts should have landed in openshift/imagebuilder#285.

@rhatdan
Copy link
Member

rhatdan commented Aug 12, 2024

Nice so this just needs plumbing with buildah and then podman.

Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Sep 12, 2024

@nalind @flouthoc any progress on this?

@nalind
Copy link
Member

nalind commented Sep 12, 2024

Yeah, the main stumbling block I hit is getting the conformance tests to pass, since they're turning up behavior which seems counterintuitive, to me at least, in a few cases.

rhatdan added a commit to rhatdan/buildah that referenced this issue Sep 12, 2024
Fixes: containers#5678

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan added a commit to rhatdan/buildah that referenced this issue Sep 12, 2024
Fixes: containers#5678

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan added a commit to rhatdan/buildah that referenced this issue Sep 12, 2024
Fixes: containers#5678

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan added a commit to rhatdan/buildah that referenced this issue Sep 12, 2024
Fixes: containers#5678

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants