Implement RUN secrets for buildah bud #3177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashley-cui The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
kind/feature
ashley-cui
force-pushed
the
secrets
branch
5 times, most recently
from
5df2ed2 to
30d545e
Compare
Signed-off-by: Ashley Cui <acui@redhat.com>
rename secrets to subscriptions and remove unused subscription package Signed-off-by: Ashley Cui <acui@redhat.com>
ashley-cui
force-pushed
the
secrets
branch
2 times, most recently
from
34d08ee to
99076ab
Compare
|
Really nice work @ashley-cui . Couple of questions, most likely to educate me more than anything else. |
|
@ashley-cui if you can make that last suggested tweak to the man page, I thnk this is GTG |
Add support for secrets. Secrets is a two-part flag that allows secret files to be accessed for a certain RUN instruction, but not any other instructions, as well as now showing up in the final image. Signed-off-by: Ashley Cui <acui@redhat.com>
|
LGTM |
1 similar comment
|
LGTM |
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add support for secrets. Secrets is a two-part flag that allows secret files to be accessed for a certain RUN instruction, but not any other instructions, as well as now showing up in the final image.
How to verify it
buildah bud --secret id=mysecret,src=secret.txt
RUN --mount=type=secret,id=mysecret
Which issue(s) this PR fixes:
Fixes: #1684