-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace k8s.gcr.io/pause in tests with registry.k8s.io/pause #4210
Replace k8s.gcr.io/pause in tests with registry.k8s.io/pause #4210
Conversation
In kubernetes 1.25, the default source for the pause image is now registry.k8s.io instead of k8s.gcr.io. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/lgtm
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, nalind, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, nalind, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind other
What this PR does / why we need it:
In kubernetes 1.25, the default source for the pause image is now registry.k8s.io instead of k8s.gcr.io (kubernetes/kubernetes#109938). Update our references to the pause image.
How to verify it
Tests should continue to pass.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?