Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] update some godocs, use 0o to prefix an octal in a comment #5702

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

nalind
Copy link
Member

@nalind nalind commented Aug 21, 2024

What type of PR is this?

/kind other

What this PR does / why we need it:

Update some godocs, and update an octal value in a godoc to start with 0o instead of just 0, to match the literal on the next line.

How to verify it

No code changes.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@rhatdan
Copy link
Member

rhatdan commented Aug 21, 2024

LGTM

Update some godocs, and update an octal value in a godoc to start with
0o instead of just 0, to match the literal on the next line.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/lgtm
/hold

Copy link
Contributor

openshift-ci bot commented Aug 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Aug 22, 2024

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit c508539 into containers:main Aug 22, 2024
24 checks passed
@nalind nalind deleted the update-some-godocs branch August 22, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants