Merge pull request #2009 from AbdelrahmanElawady/fix-data-race

Fix data race with hooks map
containers · May 22, 2024 · a1de641 · a1de641 · packit-as-a-service · May 22, 2024
2 parents 9238062 + c1056d1
commit a1de641
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/pkg/hooks/monitor.go b/pkg/hooks/monitor.go
@@ -48,13 +48,15 @@ func (m *Manager) Monitor(ctx context.Context, sync chan<- error) {
 	for {
 		select {
 		case event := <-watcher.Events:
+			m.lock.Lock()
 			m.hooks = make(map[string]*current.Hook)
 			for _, dir := range m.directories {
 				err = ReadDir(dir, m.extensionStages, m.hooks)
 				if err != nil {
 					logrus.Errorf("Failed loading hooks for %s: %v", event.Name, err)
 				}
 			}
+			m.lock.Unlock()
 		case <-ctx.Done():
 			err = ctx.Err()
 			logrus.Debugf("hook monitoring canceled: %v", err)