Skip to content

Commit

Permalink
pasta: update warnings line
Browse files Browse the repository at this point in the history
Use %s as %q just quotes/escapes everything which makes it harder to
read and trim of the last newline and spaces as well.

Also update the warnings comment, we still see warnings by default on
our debian VMs in podman CI so this cannot be on the warning level yet.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
  • Loading branch information
Luap99 committed Aug 29, 2024
1 parent f6cf41e commit e335652
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions libnetwork/pasta/pasta_linux.go
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,12 @@ func Setup(opts *SetupOptions) (*SetupResult, error) {
}

if len(out) > 0 {
// TODO: This should be warning but right now pasta still prints
// things with --quiet that we do not care about.
// For now info is fine and we can bump it up later, it is only a
// TODO: This should be warning but as of August 2024 pasta still prints
// things with --quiet that we do not care about. In podman CI I still see
// "Couldn't get any nameserver address" so until this is fixed we cannot
// enable it. For now info is fine and we can bump it up later, it is only a
// nice to have.
logrus.Infof("pasta logged warnings: %q", string(out))
logrus.Infof("pasta logged warnings: %q", strings.TrimSpace(string(out)))
}
break
}
Expand Down

0 comments on commit e335652

Please sign in to comment.