Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that zstd:chunked doesn’t make sense with encryption #2117

Closed
mtrmac opened this issue Aug 8, 2024 · 2 comments · Fixed by #2176
Closed

Document that zstd:chunked doesn’t make sense with encryption #2117

mtrmac opened this issue Aug 8, 2024 · 2 comments · Fixed by #2176

Comments

@mtrmac
Copy link
Contributor

mtrmac commented Aug 8, 2024

Encrypted images don’t benefit from zstd:chunked , and if asked to do so, the code uses non-chunked zstd (ref. containers/image#2485 .)

Around

#compression_format = "gzip"
, and for add_compression option: the documentation in comments and/or man pages [wherever the authoritative source is] should probably note that zstd:chunked is not used for encrypted images [and triggers warnings].

@mtrmac
Copy link
Contributor Author

mtrmac commented Sep 27, 2024

The documentation needs updating at least in the Podman CLI, perhaps also Buildah and Skopeo; I’ll continue tracking that here instead of filing “investigate” tickets for all projects individually.

@mtrmac
Copy link
Contributor Author

mtrmac commented Sep 30, 2024

I have filed also Skopeo, Buildah and Podman PRs.

Closing this issue now, so that I don’t have to keep checking whether any of the 4 PRs are still outstanding.

@mtrmac mtrmac closed this as completed Sep 30, 2024
openshift-merge-bot bot pushed a commit to containers/buildah that referenced this issue Oct 1, 2024
A part of containers/common#2117 .

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant