Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podman rmi --no-prune flag #1108

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

karthikelango137
Copy link
Contributor

containers/common changes for podman rmi --no-prune flag.
--no-prune does not delete dangling parent images.
For compatibility with Docker

Signed-off-by: Karthik Elango kelango@redhat.com

@rhatdan
Copy link
Member

rhatdan commented Aug 1, 2022

LGTM
@vrothberg PTAL
/approve
thanks @karthikelango137

@openshift-ci openshift-ci bot added the approved label Aug 1, 2022
containers/common changes for podman rmi --no-prune flag

Signed-off-by: Karthik Elango <kelango@redhat.com>
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I love such small but impactful changes. Nice work, @karthikelango137!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karthikelango137, rhatdan, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ab553b9 into containers:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants