Add conmon-rs paths #1117
Merged
Add conmon-rs paths #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
vrothberg
reviewed
Aug 10, 2022
Adds the conmon-rs paths so Podman can find the right conmon-rs binary when making a new runtime. I also slightly modified the `FindConmon` function so that the code could be shared with the `FindConmonRs` function that I added. Signed-off-by: Jake Correnti <jcorrenti13@gmail.com>
jakecorrenti
force-pushed
the
add-conmonrs-paths
branch
from
236b34c to
3044eb6
Compare
|
@containers/podman-maintainers PTAL |
|
LGTM |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdoern, jakecorrenti, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the conmon-rs paths so Podman can find the right conmon-rs binary
when making a new runtime.
Signed-off-by: Jake Correnti jcorrenti13@gmail.com