cgroup: do not fail with missing cpuset file #1135
Conversation
|
Cheers, thanks! I'll give it a spin on Monday or Tuesday, well into weekend time in my timezone, but it's very likely it'll work as advertised from what I can see. 👍 |
|
/lgtm |
pkg/cgroups/utils.go
Outdated
| // is not enabled in the kernel. | ||
| if os.IsNotExist(err) { | ||
| return nil, nil | ||
| } | ||
| return nil, fmt.Errorf("open %s: %w", path, err) |
There was a problem hiding this comment.
Sadly I believe this is a stutter, but not worth a repush.
There was a problem hiding this comment.
FWIW, the final message here from getting this error is "Failed to add conmon to cgroupfs sandbox cgroup: open /sys/fs/cgroup/libpod_parent/conmon/cpuset.cpus: open /sys/fs/cgroup/libpod_parent/conmon/cpuset.cpus.effective: no such file or directory" so it looks ok to me
|
Just tested (a trivial backport for 4.1.1) of this PR, it works like a charm. Both warning is gone (obviously) and other cgroups loaded successfully. Thanks! |
|
@giuseppe needs a rebase. |
if cpuset.cpus[.effective] file is missing, then ignore the error since it means the cpuset controller is not enabled in the kernel, rather than returning an error. Closes: containers#1134 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
cpuset-missing-no-error
branch
from
2871cf1 to
87fe560
Compare
|
rebased |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, giuseppe, martinetd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
fine to merge? |
|
/lgtm |
if cpuset.cpus[.effective] file is missing, then ignore the error
since it means the cpuset controller is not enabled in the kernel,
rather than returning an error.
Closes: #1134
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com