Add labels to secrets #1147
Add labels to secrets #1147
Conversation
Allow secrets to be labeled. Add new field in secrets package called label. Signed-off-by: Ashley Cui <acui@redhat.com>
|
I feel like labels are important enough and different enough from metadata (especially since each label is a key-value pair, and we're using metadata for stuff like kube) that they deserved a special field in the secrets package. @vrothberg let me know what you think |
|
LGTM |
| @@ -129,7 +131,7 @@ func NewManager(rootPath string) (*SecretsManager, error) { | |||
| // Store takes a name, creates a secret and stores the secret metadata and the secret payload. | |||
| // It returns a generated ID that is associated with the secret. | |||
| // The max size for secret data is 512kB. | |||
| func (s *SecretsManager) Store(name string, data []byte, driverType string, driverOpts map[string]string, metadata map[string]string) (string, error) { | |||
| func (s *SecretsManager) Store(name string, data []byte, driverType string, driverOpts map[string]string, metadata map[string]string, labels map[string]string) (string, error) { | |||
There was a problem hiding this comment.
There are some on-going conversations about stabilizing containers/common and bump it to v1.0.0. That means, we need to avoid breaking the API by all means.
Since this is already a breaking change, I want to take a step back and check what we can do. I think we should follow the type *Options struct pattern.
func (s *SecretsManager) Store(name string, data []byte, driverType string, options StoreOptions) (string, error) {
// ...
}It is probably worth taking a look at the other APIs as well. Feel free to merge this PR as is and do the API work in a separate PR (or commit).
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashley-cui, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I do not feel strongly about either option. Both look reasonable to me. |
|
/hold cancel |
|
If merge stuff with breaking changes we should ensure that there is a podman/buildah PR with the required fixes ready to go. Now this just blocks us from vendoring new c/common versions. So I am unable to get my my PR into Podman #1151 |
|
No, my stuff can wait until you make your podman changes. I just want to make sure we stop doing this unless we have stuff ready in podman so we do not have to block new vendor dances. |
|
@Luap99 FYI, containers/podman#15723 and #1150 should unblock you, sorry for the mess |
|
Thanks |
Allow secrets to be labeled. Add new field in secrets package called label.
Signed-off-by: Ashley Cui acui@redhat.com
Part of: containers/podman#14917